mike-jumper commented on code in PR #476:
URL: https://github.com/apache/guacamole-server/pull/476#discussion_r1447790467
##########
src/libguac/Makefile.am:
##########
@@ -171,5 +171,6 @@ libguac_la_LDFLAGS = \
@UUID_LIBS@ \
@VORBIS_LIBS@ \
@WEBP_LIBS@ \
- @WINSOCK_LIBS@
+ @WINSOCK_LIBS@ \
+ @RT_LIBS@
Review Comment:
Please maintain alphabetical ordering.
##########
configure.ac:
##########
@@ -68,6 +68,10 @@ AC_CHECK_LIB([pthread], [pthread_create],
[PTHREAD_LIBS=-lpthread
AC_DEFINE([HAVE_LIBPTHREAD],,
[Whether libpthread was found])])
+# librt
+AC_CHECK_LIB([rt], [timer_create], [RT_LIBS=-lrt],
+ AC_MSG_ERROR("librt is required for performing timer-related
operations"))
Review Comment:
It's not _universally_ required. This check should only be fatal where there
is no `timer_create()` without linking in librt. If the test determines that
`timer_create()` does not require linking with librt, this check should pass
and `RT_LIBS` should be empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
