jmuehlner commented on PR #942: URL: https://github.com/apache/guacamole-client/pull/942#issuecomment-1889700563
> > > Maybe it won't be a big deal, but I wonder if there are folks who use the arguments in the menu today and are used to just closing the menu without clicking away from the fields and expecting that this will result in both the value being set/sent and in focus automatically returning to the client. > > > > > > Sorry, I should have been more clear that this is just _allowing_ extensions to take advantage of this new functionality. All existing extensions and the fields that they define should behave exactly the same as before. > > Ah, okay, so the `fieldIsFocused` property won't automatically be used by any/all fields - only when it's specifically implemented? Yeah, it won't have any effect unless it's explicitly set by a field doing a `$scope.$emit()` call - and in any case is only really relevant if you want a field that can be typed into while the menu is closed - as those keypresses would otherwise be eaten up by the global input sink and not make it to the field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
