jmuehlner commented on code in PR #942:
URL: https://github.com/apache/guacamole-client/pull/942#discussion_r1450999278
##########
guacamole/src/main/frontend/src/app/client/templates/client.html:
##########
@@ -47,7 +47,7 @@
<!-- Menu -->
<div class="menu" ng-class="{open: menu.shown}" id="guac-menu">
- <div class="menu-content" ng-if="menu.shown"
guac-touch-drag="menuDrag">
+ <div class="menu-content" guac-touch-drag="menuDrag">
Review Comment:
I can't see any way to add the desired functionality (being able to render
fields when the menu is closed) and keep that `ng-if`. These are definitionally
incompatible.
I'll try those steps to make sure that the problem is actually gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
