neandrake commented on PR #316: URL: https://github.com/apache/guacamole-server/pull/316#issuecomment-1901175154
> @neandrake Can you clarify the need behind [6ff5952](https://github.com/apache/guacamole-server/commit/6ff5952f03e78b381463d0649e3392a8d4860feb)? The commit message is clear, but the additional mutex appears to only guard functions that are already guarded by the mutex built into `guac_common_display`. Usage of `guac_socket` should also already be threadsafe. I've removed those changes from my branch I linked earlier. The issue I was seeing had a root cause of using TLS sockets with multiple active connections. I reported as GUACAMOLE-1910 and submitted a PR in https://github.com/apache/guacamole-server/pull/482. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
