necouchman commented on code in PR #931:
URL: https://github.com/apache/guacamole-client/pull/931#discussion_r1510407891
##########
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java:
##########
@@ -306,17 +311,43 @@ public LDAPAuthenticatedUser authenticateUser(Credentials
credentials)
}
}
+ /**
+ * Returns parameter current ldap domain token generated from user
credentials
+ * If no multiple LDAP are configured on GUACAMOLE_HOME such
ldap-servers.yaml,
+ * a null is returned.
Review Comment:
Is this actually the way it works - if multiple LDAP servers/domains are not
enabled, will it _always_ return `null`? Or are there situations where a single
LDAP configuration could still result in a value being returned by this
function - such as if the `userPrincipalName` attribute is used when talking to
Active Directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
