jmuehlner commented on code in PR #496:
URL: https://github.com/apache/guacamole-server/pull/496#discussion_r1520514157
##########
src/protocols/rdp/rdp.c:
##########
@@ -525,12 +525,24 @@ static int guac_rdp_handle_connection(guac_client*
client) {
/* Set default pointer */
guac_common_cursor_set_pointer(rdp_client->display->cursor);
+ /*
+ * Downgrade the lock to allow for concurrent read access
+ * Access to read locks need to be made available for other processes to
use
+ * while we await credentials from the user.
+ */
+ pthread_rwlock_unlock(&(rdp_client->lock));
Review Comment:
Sorry, I was unclear here. What I meant was using `guac_rwlock` to convert
the entire `rdp_client->lock` into a reentrant rwlock, so you could keep the
current read lock around the `freerdp_connect()` call, and then additionally
grab the write lock, but only when the `rdp_client->audio_input` (or any
assignment) is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
