necouchman commented on PR #956: URL: https://github.com/apache/guacamole-client/pull/956#issuecomment-1991366511
@StephanRichter Thanks. One other thing - there's already a PR out there that deals with this - #902. While that is my PR, I'm not opposed to someone else stepping in and working on it; however, there's already been a fair amount of discussion about how to handle it, and the other PR deals more broadly with how to handle username comparison across multiple authentication modules, versus the approach of just forcing the username to a given case and assuming everything will handle it correctly from there. The approach you've taken, here, is much simpler, but I'm not sure that it covers all of the possible scenarios of dealing with multiple modules (JDBC + SSO or JDBC + LDAP, for example). I'm happy to have further discussion on the merits of one approach versus another, and I know that the previously mentioned PR has languished a bit, so, again, I'm not opposed to others stepping in to help with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
