jmuehlner commented on code in PR #967:
URL: https://github.com/apache/guacamole-client/pull/967#discussion_r1554287797
##########
guacamole/src/main/frontend/src/app/manage/controllers/manageConnectionController.js:
##########
@@ -318,6 +318,7 @@
angular.module('manage').controller('manageConnectionController', ['$scope', '$i
*/
$scope.cloneConnection = function cloneConnection() {
$location.path('/manage/' +
encodeURIComponent($scope.selectedDataSource) + '/connections').search('clone',
identifier);
+ $window.scrollTo(0,0);
Review Comment:
[$window](https://docs.angularjs.org/api/ng/service/$window) is an angularjs
service, and while it _might_ be automagically included somehow from something
else (like jQuery), it's probably a bad idea to just assume that it'll always
be implicitly present. Much better to explicitly use the angularjs service IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
