mike-jumper commented on code in PR #973: URL: https://github.com/apache/guacamole-client/pull/973#discussion_r1563677842
########## doc/licenses/spring-web-5.3.33/README: ########## @@ -1,7 +1,7 @@ Spring Framework (https://spring.io/projects/spring-framework) -------------------------------------------------------------- - Version: 5.3.25 + Version: 5.3.33 Review Comment: I think we can avoid Spring entirely here - I see it used in guacamole-auth-duo only for `UriComponentsBuilder`: ```java String builtUrl = UriComponentsBuilder .fromUriString(redirectUrl) .queryParam(Credentials.RESUME_QUERY, DuoAuthenticationProvider.PROVIDER_IDENTIFER) .build() .toUriString(); ``` I _think_ this can be rewritten to just use `UriBuilder`: https://javaee.github.io/javaee-spec/javadocs/javax/ws/rs/core/UriBuilder.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
