jmuehlner commented on code in PR #976:
URL: https://github.com/apache/guacamole-client/pull/976#discussion_r1569097062
##########
guacamole-ext/src/main/resources/org/apache/guacamole/protocols/vnc.json:
##########
@@ -58,6 +58,14 @@
"type" : "BOOLEAN",
"options" : [ "true" ]
},
+ {
+ "name" : "compress-level",
+ "type" : "NUMERIC"
Review Comment:
That's a neat idea, though I think it might make more sense when there's
more options than this (when it's hard to just enumerate the possibilities, but
still only certain values are valid). This is quite a bit fewer options than
e.g. font-size:
```
{
"name" : "font-size",
"type" : "ENUM",
"options" : [ "", "8", "9", "10", "11", "12", "14", "18", "24", "30",
"36", "48", "60", "72", "96" ]
},```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
