leonard2901 commented on code in PR #896:
URL: https://github.com/apache/guacamole-client/pull/896#discussion_r1575673864


##########
guacamole/src/main/guacamole-frontend/package.json:
##########
@@ -0,0 +1,61 @@
+{
+    "name": "frontend",
+    "version": "0.0.0",
+    "scripts": {
+        "ng": "ng",
+        "start": "ng serve",
+        "build": "ng build",
+        "build:app": "ng build guacamole-frontend --base-href /guacamole/",

Review Comment:
   We internally discussed the issue with the the static base-href 
configuration. As Angular requires the base path to be set at compile time, 
dynamically adjusting it isn't straightforward.
   
   Our suggestion would be to keep the `--base-href guacamole` setup for now. 
However, as a workaround, users who need to deploy the webapp at a different 
base can manually adjust the base path: they would need to unpack the .war 
file, edit the base href in the index.html file to the desired path, and then 
repackage it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to