mike-jumper opened a new pull request, #979: URL: https://github.com/apache/guacamole-client/pull/979
This change strips away much of the manual mapping of environment variables to properties, instead relying on automatic mapping of properties using `enable-environment-properties`. `*_FILE` environment variables are also automatically mapped. Additionally: * The structure of the startup process of the Docker image has been split across multiple scripts for maintainability and extensibility. * The log level can now be set with a convenient `log-level` property that maps to the `LOG_LEVEL` environment variable. * `REMOTE_IP_VALVE_*` environment variables have been renamed to align with the attributes being configured. * The default `GUACAMOLE_HOME` is now transient and randomly generated to allow users to use the familiar `/etc/guacamole` location for their configuration template without potential collisions. Users can even use `/etc/guacamole` directly without overriding `GUACAMOLE_HOME` and rely on the image to combine what they've provided with anything the image has configured via environment variables. As of these changes, there are only two mappings that must be manually maintained (and then only when a new extension is introduced): 1. A mapping of environment variable prefixes to their corresponding extension `.jar` files. This is handled by `guacamole-docker/build.d/010-map-guacamole-extensions.sh`. 2. A mapping of environment variable prefixes to their corresponding driver `.jar` files (ie: JDBC drivers). This is handled by `guacamole-docker/build.d/020-download-drivers.sh`. Both of the above mappings/scripts organize things within a directory hierarchy that allows the entrypoint to easily link extensions, drivers, etc. into place based on which environment variables are set. Once the extensions are in place, everything else is implicit via `enable-environment-properties`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
