Re: [PR] GUACAMOLE-1586: Don't add \n in clipboard if the line isn't finished. [guacamole-server]

[via GitHub]

corentin-soriano commented on PR #512:
URL: https://github.com/apache/guacamole-server/pull/512#issuecomment-2074228952

   We must keep this existing logic :
   - first row = start_col to $
   - middle rows = ^ to $
   - last row = ^ to end_col
   
   With `guac_terminal_clipboard_append_row(terminal, row, start_col, 
end_col);` for each row, we risk having a rectangular selection of this type :
   
![image](https://github.com/apache/guacamole-server/assets/107032768/a764ebff-0199-4637-a40f-bc2369af2d2e)
   We need to keep this selection format here :
   
![image](https://github.com/apache/guacamole-server/assets/107032768/6c540f7c-40de-42ff-8775-ca75f93cc337)
   
   
   However, I noticed that if we select a row that has exactly the same number 
of columns as the display, it will be missing a \n :
   Example :
   
![image](https://github.com/apache/guacamole-server/assets/107032768/3008b34c-88c8-4de4-aed3-6d73c6684753)
   Content of clipboard :
   ```
   [root@vm01 ~]# echo -e 
"eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee\ntest\ntest2"
   eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeetest
   test2
   ```
   This case is very rare but can exist.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org