Re: [PR] GUACAMOLE-1267: Add VNC setting 'disable-remote-input' [guacamole-server]

[via GitHub]

mike-jumper commented on code in PR #501:
URL: https://github.com/apache/guacamole-server/pull/501#discussion_r1585928312


##########
src/protocols/vnc/vnc.c:
##########
@@ -416,6 +416,20 @@ void* guac_vnc_client_thread(void* data) {
     }
 #endif
 
+    /* Disable remote console (Server input) */
+    if (settings->disable_server_input) {
+        rfbSetServerInputMsg msg;
+        msg.type = rfbSetServerInput;
+        msg.status = 1;
+        msg.pad = 0;
+
+        if (WriteToRFBServer(rfb_client, (char*)&msg, sz_rfbSetServerInputMsg))
+            guac_client_log(client, GUAC_LOG_DEBUG, "Successfully sent request 
to disable server input.");
+
+       else
+            guac_client_log(client, GUAC_LOG_WARNING, "Failed to send request 
to disable server input.");

Review Comment:
   A tab snuck in here an is causing the `else` to appear misaligned:
   
   ![Screenshot of misaligned else due to 
tab](https://github.com/apache/guacamole-server/assets/4632905/fa9cdb3b-b096-46bf-a462-dbfead2d913c)
   



##########
src/protocols/vnc/settings.c:
##########
@@ -351,6 +353,12 @@ enum VNC_ARGS_IDX {
      * using the clipboard. By default, clipboard access is not blocked.
      */
     IDX_DISABLE_PASTE,
+
+    /*

Review Comment:
   This should be `/**` (Doxygen-style comment).



##########
src/protocols/vnc/vnc.c:
##########
@@ -416,6 +416,20 @@ void* guac_vnc_client_thread(void* data) {
     }
 #endif
 
+    /* Disable remote console (Server input) */
+    if (settings->disable_server_input) {
+        rfbSetServerInputMsg msg;
+        msg.type = rfbSetServerInput;
+        msg.status = 1;
+        msg.pad = 0;
+
+        if (WriteToRFBServer(rfb_client, (char*)&msg, sz_rfbSetServerInputMsg))
+            guac_client_log(client, GUAC_LOG_DEBUG, "Successfully sent request 
to disable server input.");
+
+       else
+            guac_client_log(client, GUAC_LOG_WARNING, "Failed to send request 
to disable server input.");

Review Comment:
   A tab snuck in here an is causing the `else` to appear misaligned.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org