necouchman commented on code in PR #228:
URL: https://github.com/apache/guacamole-manual/pull/228#discussion_r1586157091
##########
src/duo-auth.md:
##########
@@ -110,57 +110,46 @@ The application-specific configuration information
retrieved from Duo
must be added to `guacamole.properties` to describe how Guacamole
should connect to the Duo service:
-duo-api-hostname
+`duo-api-hostname`
: The hostname of the Duo API endpoint to be used to verify user identities.
- This will usually be in the form `api-XXXXXXXX.duosecurity.com`, where
- "XXXXXXXX" is some arbitrary alphanumeric value assigned by Duo. This
- value will have been generated by Duo when you added Guacamole as an "Web
- SDK" application, and can be found within the application details in the
- "API hostname" field. *This value is required.*
+ This will usually be in the form {samp}`api-{XXXXXXXX}.duosecurity.com`,
+ where {samp}`{XXXXXXXX}` is some arbitrary alphanumeric value assigned by
+ Duo. This value will have been generated by Duo when you added Guacamole as
+ an "Web SDK" application, and can be found within the application details in
+ the "API hostname" field. *This value is required.*
-duo-integration-key
+`duo-client-id`
: The integration key provided for Guacamole by Duo. This value will
have been generated by Duo when you added Guacamole as an "Web SDK"
application, and can be found within the application details in the
- "Integration key" field. *This value is required and must be EXACTLY
- 20 characters.*
+ "Client ID" field. *This value is required.*
Review Comment:
* Is this still an "integration key", or should this first line be changed
to something like `The client identifier provided for Guacamole...`?
* While we're here modifying this block, perhaps change "an" to "a": `a "Web
SDK"`
##########
src/duo-auth.md:
##########
@@ -110,57 +110,46 @@ The application-specific configuration information
retrieved from Duo
must be added to `guacamole.properties` to describe how Guacamole
should connect to the Duo service:
-duo-api-hostname
+`duo-api-hostname`
: The hostname of the Duo API endpoint to be used to verify user identities.
- This will usually be in the form `api-XXXXXXXX.duosecurity.com`, where
- "XXXXXXXX" is some arbitrary alphanumeric value assigned by Duo. This
- value will have been generated by Duo when you added Guacamole as an "Web
- SDK" application, and can be found within the application details in the
- "API hostname" field. *This value is required.*
+ This will usually be in the form {samp}`api-{XXXXXXXX}.duosecurity.com`,
+ where {samp}`{XXXXXXXX}` is some arbitrary alphanumeric value assigned by
+ Duo. This value will have been generated by Duo when you added Guacamole as
+ an "Web SDK" application, and can be found within the application details in
+ the "API hostname" field. *This value is required.*
-duo-integration-key
+`duo-client-id`
: The integration key provided for Guacamole by Duo. This value will
have been generated by Duo when you added Guacamole as an "Web SDK"
application, and can be found within the application details in the
- "Integration key" field. *This value is required and must be EXACTLY
- 20 characters.*
+ "Client ID" field. *This value is required.*
-duo-secret-key
+ This value was formerly known as the "integration key" in older versions of
+ Duo's "Web SDK" and was configured with the `duo-integration-key` property
+ in older versions of Guacamole.
+
+`duo-client-secret`
: The secret key provided for Guacamole by Duo. This value will have
Review Comment:
As with above - does it make sense to change this to `The client secret`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
