jmuehlner commented on PR #504:
URL: https://github.com/apache/guacamole-server/pull/504#issuecomment-2136156483
This looks good to me, aside from a minor punctuation mistake. My only other
request would be that some of these commits be reworded and / or squashed.
Each commit should:
* Follow the format `GUACAMOLE-1234: Clarify commit message expectations.`,
with the first word capitalized, and a period after the message.
* Cleary explain what the commit is intended to do.
Something like `GUACAMOLE-192: revert removed line` is unclear about what
line is being reverted, and whether it's a substantive change or not. If it's
just a minor whitespace fix, I'd suggest just squashing it into whatever commit
its related to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
