jmuehlner commented on code in PR #991:
URL: https://github.com/apache/guacamole-client/pull/991#discussion_r1625136467
##########
guacamole/src/main/frontend/package.json:
##########
Review Comment:
Packages that are not upgraded:
* Webpack along with all associated plugins and loaders
`angular-templatecache-webpack-plugin` has not been updated in 3 years and
requires webpack 4, and we are already on the latest version of all webpack-4
compatible packages.
* `@simonwep/pickr`
Version 1.9.1 is available, but fails to compile/parse:
```
[INFO] ERROR in ./node_modules/@simonwep/pickr/dist/pickr.min.js 2:9541
[INFO] Module parse failed: Unexpected token (2:9541)
[INFO] You may need an appropriate loader to handle this file type,
currently no loaders are configured to process this file. See
https://webpack.js.org/concepts#loaders
[INFO] | /*! Pickr 1.9.1 MIT | https://github.com/Simonwep/pickr */
[INFO] > !function(t,e){"object"==typeof exports&&"object"==typeof
module?module.exports=e():"function"==typeof
define&&define.amd?define([],e):"object"==typeof
exports?exports.Pickr=e():t.Pickr=e()}(self,(()=>(()=>{"use strict";var
t={d:(e,o)=>{for(var n in
o)t.o(o,n)&&!t.o(e,n)&&Object.defineProperty(e,n,{enumerable:!0,get:o[n]})},o:(t,e)=>Object.prototype.hasOwnProperty.call(t,e),r:t=>{"undefined"!=typeof
Symbol&&Symbol.toStringTag&&Object.defineProperty(t,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(t,"__esModule",{value:!0})}},
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
