necouchman commented on code in PR #527:
URL: https://github.com/apache/guacamole-server/pull/527#discussion_r1642740269


##########
Dockerfile:
##########
@@ -186,6 +203,7 @@ ARG UID=1000
 ARG GID=10001
 RUN groupadd --gid $GID guacd
 RUN useradd --system --create-home --shell /sbin/nologin --uid $UID --gid $GID 
guacd
+COPY ./src/guacd-docker/krb5.conf /etc/krb5.conf

Review Comment:
   I'm not sure we should provide this - maybe just document the instructions 
for it.



##########
src/guacd-docker/krb5.conf:
##########
@@ -0,0 +1,16 @@
+[libdefaults]
+    default_realm = PROCYON.COM
+    dns_lookup_kdc = true
+    dns_lookup_realm = true
+
+[realms]
+    PROCYON.COM = {
+        kdc = cez-private.procyon.com
+        admin_server = cez-private.procyon.com
+        master_kdc = cez-private.procyon.com
+        default_domain = procyon.com
+    }
+
+[domain_realm]
+    .procyon.com = PROCYON.COM
+    procyon.com = PROCYON.COM

Review Comment:
   I think this file should be removed from the commit - this looks like 
something internal to your configuration. I'm not sure that we should provide a 
template for this - maybe just document instructions for it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to