corentin-soriano commented on PR #505: URL: https://github.com/apache/guacamole-server/pull/505#issuecomment-2175269277
> > > > > Just one request - `#define` things that should be constants. > > > > > > > > > > > > Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define? > > > > > > > > > Well, we're trying to improve that: > > > https://issues.apache.org/jira/browse/GUACAMOLE-287 > > > > > > While I was at it, I added #define constants for the entirety of the __guac_terminal_send_key function and broke up overly long lines. > > Feel free to let me know if I should move the declarations to another file or if it would be better to comment each #define. > > Would you prefer that I move the second commit to a new pull request?" > > Wow, thank you. I'm good with them all being in this pull request, but could you move them to a header file - guessing `terminal.h`? > > As far as comments go, to be consistent we'll probably need a comment/documentation for each `#define`, but I'll let @mike-jumper or @jmuehlner add any comments they have on that... #defines moved to terminal.h If necessary, I will add a comment by #define rather than by block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
