lukasraska opened a new pull request, #530: URL: https://github.com/apache/guacamole-server/pull/530
This PR introduces new `recording-include-clipboard` into all supported protocols that dumps the `clipboard` instruction, along with the relevant stream blobs, into recording. Few key notes: - because clipboard can contain sensitive data, it's opt-in in the same way as `recording-include-keys` and administrators need to explicitly set the parameter to `true` - as the recording components are responsible for handling the recording dumps, `guac_recording_create` includes the new parameter (i've opted for making it the last argument, but let me know if I should switch it to be next to the `include_keys`) - the keyboard dumps are hooked into user clipboard handler, so should only handle changes from user side and not from the server side - as clipboard instruction merely creates stream, even the simplest paste is essentially at least 3 instructions (clipboard, 1+ blobs, end), which can be seen like this in some testing recording ``` $ sed 's/;/\n/g' recording-clipboard | grep clipboard -A 2 9.clipboard,1.0,10.text/plain 4.blob,1.0,20.UHVsbCBjb21wbGV0ZQ== 3.end,1.0 ``` Once this PR is approved from technical perspective, I will create respective PRs for guacamole-client and guacamole-manual to accomodate for both documentation change as well the client side option -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
