necouchman commented on PR #911:
URL: https://github.com/apache/guacamole-client/pull/911#issuecomment-2255946385

   > I was having a look at this pull request because this functionality will 
be very useful. But I am hitting two compile errors:
   > 
   > [ERROR] 
..../guacamole-client/extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/UserVerificationService.java:[178,20]
 error: variable credentials is already defined in method 
verifyAuthenticatedUser(AuthenticatedUser) [ERROR] 
..../guacamole-client/extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/UserVerificationService.java:[179,27]
 error: variable request is already defined in method 
verifyAuthenticatedUser(AuthenticatedUser)
   > 
   > Im not sure if this is my mishandling of git, but if I look at the file in 
the pull request I can see the two definitions there too. I think it is 
probably just as simple as removing the second set of definitions? ... or 
fixing my understanding of git.
   
   It should be fixed, now - apparently I didn't verify that it compiled after 
the last round of changes I made. Oops.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to