scottp-dpaw commented on PR #533: URL: https://github.com/apache/guacamole-server/pull/533#issuecomment-2259565101
No worries. In lieu of making constants for every bitmask, I've added clearer comments describing the sequence of bits that we're trying to find for each codepoint. Hopefully that should provide enough context to the reader about what we're trying to do, if not I'm open to suggestions. Gotta say writing out more comments was a worthwhile exercise; I found two errors with my original logic. Turns out Unicode is hard! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
