mike-jumper commented on code in PR #677:
URL: https://github.com/apache/guacamole-client/pull/677#discussion_r1735094841
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java:
##########
@@ -416,6 +462,21 @@ private GuacamoleTunnel
assignGuacamoleTunnel(ActiveConnectionRecord activeConne
GuacamoleClientInformation info, Map<String, String> tokens,
boolean interceptErrors) throws GuacamoleException {
+ // Set up JDBC-specific tokens
+ tokens.put(JDBC_DATE_TOKEN,
+ new SimpleDateFormat(JDBC_DATE_TOKEN_FORMAT)
+ .format(activeConnection.getStartDate()));
+ tokens.put(JDBC_TIME_TOKEN,
+ new SimpleDateFormat(JDBC_TIME_TOKEN_FORMAT)
+ .format(activeConnection.getStartDate()));
Review Comment:
I think I'm good with keeping things specific to `GUAC_JDBC_*` here,
particularly given the expected complexity of the generalized approach. The
`GUAC_JDBC_*` tokens are reasonable as they stand and will scratch the
community's itch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
