jmuehlner commented on code in PR #525: URL: https://github.com/apache/guacamole-server/pull/525#discussion_r1735366761
########## src/libguac/tests/rect/intersects.c: ########## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include <CUnit/CUnit.h> +#include <guacamole/rect.h> + +/** + * Test which verifies intersection testing via guac_rect_intersects(). + */ +void test_rect__intersects() { + + int res; + + guac_rect min; + guac_rect rect; + + guac_rect_init(&min, 10, 10, 10, 10); + + /* Rectangle intersection - empty + * rectangle is outside */ + guac_rect_init(&rect, 25, 25, 5, 5); + res = guac_rect_intersects(&rect, &min); + CU_ASSERT_FALSE(res); + + /* Rectangle intersection - empty + * rectangle is outside */ + guac_rect_init(&rect, 20, 20, 5, 5); + res = guac_rect_intersects(&rect, &min); + CU_ASSERT_FALSE(res); + + /* Rectangle intersection - complete + * rectangle is completely inside */ + guac_rect_init(&rect, 11, 11, 5, 5); + res = guac_rect_intersects(&rect, &min); + CU_ASSERT_TRUE(res); + + /* Rectangle intersection - partial + * rectangle intersects UL */ + guac_rect_init(&rect, 8, 8, 5, 5); + res = guac_rect_intersects(&rect, &min); + CU_ASSERT_TRUE(res); + + /* Rectangle intersection - partial + * rectangle intersects LR */ + guac_rect_init(&rect, 18, 18, 5, 5); + res = guac_rect_intersects(&rect, &min); + CU_ASSERT_TRUE(res); + + /* Rectangle intersection - complete + * rect intersects along UL but inside */ + guac_rect_init(&rect, 10, 10, 5, 5); + res = guac_rect_intersects(&rect, &min); + CU_ASSERT_TRUE(res); + + /* Rectangle intersection - partial Review Comment: This terminoloy here about a partial rectangle intersection is sort of confusing - it looks like these rectangles are _touching_ at an edge, but not actually overlapping, right? Maybe consider rewording to make it clearer what these comments mean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
