jmuehlner commented on code in PR #546:
URL: https://github.com/apache/guacamole-server/pull/546#discussion_r1747741672
##########
src/protocols/rdp/rdp.c:
##########
@@ -194,21 +247,11 @@ BOOL rdp_freerdp_pre_connect(freerdp* instance) {
primary->MemBlt = guac_rdp_gdi_memblt;
primary->OpaqueRect = guac_rdp_gdi_opaquerect;
- /* Load "rdpgfx" plugin for Graphics Pipeline Extension */
- if (settings->enable_gfx)
- guac_rdp_rdpgfx_load_plugin(context);
-
- /* Load plugin providing Dynamic Virtual Channel support, if required */
- if (freerdp_settings_get_bool(GUAC_RDP_CONTEXT(instance)->settings,
FreeRDP_SupportDynamicChannels) &&
- guac_freerdp_channels_load_plugin(context, "drdynvc",
- GUAC_RDP_CONTEXT(instance)->settings)) {
- guac_client_log(client, GUAC_LOG_WARNING,
- "Failed to load drdynvc plugin. Display update and audio "
- "input support will be disabled.");
- }
+ #ifndef RDP_INST_HAS_LOAD_CHANNELS
+ rdp_freerdp_load_channels(instance);
Review Comment:
That looks better - mind updating the documentation for
`rdp_freerdp_pre_connect()`, which still ties this to the FreeRDP version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
