jmuehlner commented on code in PR #550:
URL: https://github.com/apache/guacamole-server/pull/550#discussion_r1755738981


##########
src/protocols/vnc/display.c:
##########
@@ -51,16 +51,10 @@ void guac_vnc_update(rfbClient* client, int x, int y, int 
w, int h) {
     guac_client* gc = rfbClientGetClientData(client, GUAC_VNC_CLIENT_KEY);
     guac_vnc_client* vnc_client = (guac_vnc_client*) gc->data;
 
-#ifdef LIBVNC_CLIENT_HAS_SCREEN
-    int new_height = rfbClientSwap16IfLE(client->screen.height);
-    int new_width  = rfbClientSwap16IfLE(client->screen.width);
-#else
-    int new_height = rfbClientSwap16IfLE(client->height);

Review Comment:
   This was wrong anyway - the bit swap should not happen on the client height 
and width.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to