jmuehlner commented on code in PR #1004:
URL: https://github.com/apache/guacamole-client/pull/1004#discussion_r1805446546
##########
guacamole-ext/src/main/java/org/apache/guacamole/token/TokenFilter.java:
##########
@@ -225,15 +225,21 @@ private String filter(String input, boolean strict)
// strict mode is enabled
if (tokenValue == null) {
+ // Token marked as optional, so just skip it and update
+ // last match.
+ if (modifier != null && modifier.equals("OPTIONAL")) {
Review Comment:
Hmm, on second thought, maybe this should be at debug level? If used for its
intended purpose this would make the logs pretty spammy. Sorry for the trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
