jmuehlner commented on code in PR #559:
URL: https://github.com/apache/guacamole-server/pull/559#discussion_r1806863150
##########
src/protocols/rdp/settings.c:
##########
@@ -1263,6 +1271,20 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
settings->gateway_port =
guac_user_parse_args_int(user, GUAC_RDP_CLIENT_ARGS, argv,
IDX_GATEWAY_PORT, 443);
+
+ char* gateway_type = guac_user_parse_args_string(user,
GUAC_RDP_CLIENT_ARGS,
Review Comment:
To be more clear, it'd be nice if there was some documentation somewhere in
here that briefly explains what happens in the default case where the
`gateway-type` parameter isn't set (or is set to some invalid value).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
