jmuehlner commented on code in PR #999: URL: https://github.com/apache/guacamole-client/pull/999#discussion_r1809624126
########## guacamole-common-js/src/main/webapp/modules/Keyboard.js: ########## @@ -885,7 +885,12 @@ Guacamole.Keyboard = function Keyboard(element) { for (var i = 0; i < str.length; i++) { // Determine keysym of current character - var codepoint = str.codePointAt ? str.codePointAt(i) : str.charCodeAt(i); + var codepoint = str.codePointAt(i); Review Comment: I don't think we should remove the checks for `codePointAt` - it was only added in mid-2017. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org