mike-jumper commented on code in PR #1035:
URL: https://github.com/apache/guacamole-client/pull/1035#discussion_r1859051303
##########
guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json:
##########
@@ -191,6 +191,11 @@
"type" : "ENUM",
"options" : [ "", "preserve", "unix", "windows" ]
},
+ {
+ "name" : "clipboard-buffer-size",
+ "type" : "ENUM",
+ "options" : [ "262144", "1048576", "10485760" ]
Review Comment:
There should also be a `""` option to permit the default value to be
selected and represented (same for the other protocols).
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -826,6 +842,7 @@
"FIELD_HEADER_COLOR_SCHEME" : "Color scheme:",
"FIELD_HEADER_CREATE_RECORDING_PATH" : "Automatically create recording
path:",
"FIELD_HEADER_CREATE_TYPESCRIPT_PATH" : "Automatically create
typescript path:",
+ "FIELD_HEADER_CLIPBOARD_BUFFER_SIZE" : "Clipboard data size limit:",
Review Comment:
Please maintain established alphabetical ordering of the translation keys
(same for other protocols).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
