necouchman commented on code in PR #1041:
URL: https://github.com/apache/guacamole-client/pull/1041#discussion_r1901013144
##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-cas/pom.xml:
##########
@@ -77,9 +77,20 @@
<artifactId>commons-codec</artifactId>
</exclusion>
+ <exclusion>
Review Comment:
Might be useful to document the reason for the exclusions, here?
##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-saml/pom.xml:
##########
@@ -143,14 +143,19 @@
<artifactId>commons-codec</artifactId>
</exclusion>
+ <exclusion>
Review Comment:
Might be useful to have a comment documenting the reason for the exclusions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
