I did apply but never heard back. It is not a big deal since this is not a major issue for me.
Unfortunately my C is very limited. I would not be able to make many useful code contributions. Thanks Sent with Proton Mail secure email. On Tuesday, January 14th, 2025 at 1:23 PM, Nick Couchman <vn...@apache.org> wrote: > On Tue, Jan 14, 2025 at 11:06 AM viktor_krumm > viktor_kr...@proton.me.invalid wrote: > > > I would have suggested this in Jira as a feature request, but I do not > > seem to have access. > > You're welcome to apply for a Jira account - just make sure when asked for > the justification that you mention you have this feature requested related > to Telnet so that we can approve the account. > > > When using Guacamole Telnet client to access a remote host, it was > > duplicating echo. This was a simple fix in src/protocols/telnet/client.c > > line 78. I changed echo_enabled from 1 to 0. This required recompiling the > > C code. I rebuilt the docker image for guacamole-server, and deployed the > > custom image instead of the Apache image. > > > > This feature request is to possibly expose that option in the Guacamole > > client itself, like many of the VNC and SSH options. Is it possible to > > rewrite the C code to accept those parameters as runtime variables? Or > > dockerfile build parameters? Or is that too complicated for a simple and > > likely rarely used feature? > > This sounds very doable, and should be a pretty simple feature to > implement. Once you have the Jira account and ticket, if you'd like to, > feel free to take a try at submitting a pull request with the changes you'd > like to make to add this as an option. You can go back and look at previous > pull requests that have added various options for examples, and we'll try > to guide you through the process once the pull request is submitted. It's > also worth reading the following page: > > https://guacamole.apache.org/open-source/ > > -Nick
