necouchman commented on PR #1068: URL: https://github.com/apache/guacamole-client/pull/1068#issuecomment-2706905557
> Hi @necouchman, > > * Re tagging: Can you elaborate on it a bit? Do I tag the PR with the JIRA item or the other way around? Both PR and Commit messages should be tagged with the Jira item. The PR you've done correctly, here, with the `GUACMAOLE-1746: Docker allow usage of custom keystore and custom certificate`. However, the commit messages need this same `GUACAMOLE-1746` prepended to the beginning of the message, for example: `GUACAMOLE-1746: Add the environment variables for custom keystore and certificate to the docker startup script.` You can look at other in-progress or merged PRs to see examples of this. > * How do I edit the commit messages? Do you suggest recreating them? I find that the easiest way to do this is to do an interactive rebase (`git rebase -i <COMMIT BEFORE YOUR COMMIT>`), then, for each commit message you want to re-word, change the "pick" to "r" or "reword", edit the commit messages for each commit, and finally force-push the commits (`git push -f`). This will automatically update the PR, as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
