mike-jumper commented on code in PR #262:
URL: https://github.com/apache/guacamole-manual/pull/262#discussion_r2006100548
##########
.github/workflows/pr-build.yml:
##########
@@ -26,4 +26,16 @@ jobs:
- name: Build Docker container
shell: sh
run: |
- docker build --pull --no-cache --force-rm .
+ docker build --pull --no-cache --tag built-manual-image .
+ docker create --name built-manual-container built-manual-image
+ docker cp built-manual-container:/usr/local/apache2/htdocs
"$RUNNER_TEMP/htdocs"
+ docker container rm --force --volumes built-manual-container
Review Comment:
I think you can avoid keeping the temporary container across multiple
commands by replacing this with something like:
```
docker run --rm built-manual-image tar -C /usr/local/apache2 -c htdocs | tar
-C "$RUNNER_TEMP" -x
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
