mike-jumper commented on code in PR #597:
URL: https://github.com/apache/guacamole-server/pull/597#discussion_r2124893731
##########
src/terminal/terminal.c:
##########
@@ -868,6 +868,14 @@ void guac_terminal_scroll_up(guac_terminal* term,
void guac_terminal_scroll_down(guac_terminal* term,
int start_row, int end_row, int amount) {
+ /*
+ * This is necessary because guac_terminal_copy_rows will set new
GUAC_CHAR_COPY
+ * for cells of shifted rows meanwhile preceding GUAC_CHAR_SET for these
cells
+ * are not actually done yet. The GUAC_CHAR_COPY operation has the highest
priority,
+ * so if we do not 'flush' here, wrong content will be copied.
+ */
+ guac_terminal_display_flush(term->display);
Review Comment:
So, should we move:
https://github.com/apache/guacamole-server/blob/d80112c993a352c4e366317c0ae12919bfa61011/src/terminal/display.c#L865-L868
into its own function, perhaps something like
`guac_terminal_display_flush_operations()`, and then call _that_ instead? That
would at least avoid the unnecessary `guac_common_surface_flush()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
