jseifeddine commented on PR #534:
URL: https://github.com/apache/guacamole-server/pull/534#issuecomment-2954340072
> I cloned your PR, docker build fails
>
> ```
> 468.9 Added: sv-se-qwerty
> 468.9 Added: da-dk-qwerty
> 468.9 Added: tr-tr-qwerty
> 468.9 make all-recursive
> 468.9 make[3]: Entering directory '/tmp/guacamole-server/src/protocols/rdp'
> 468.9 Making all in .
> 468.9 make[4]: Entering directory '/tmp/guacamole-server/src/protocols/rdp'
> 468.9 CC
plugins/guac-common-svc/libguac_common_svc_client_la-guac-common-svc.lo
> 469.2 In file included from
/opt/guacamole/lib/pkgconfig/../../include/freerdp3/freerdp/client/rdpgfx.h:28,
> 469.2 from
/opt/guacamole/lib/pkgconfig/../../include/freerdp3/freerdp/gdi/gdi.h:34,
> 469.2 from
/opt/guacamole/lib/pkgconfig/../../include/freerdp3/freerdp/freerdp.h:35,
> 469.2 from ./channels/common-svc.h:23,
> 469.2 from plugins/guac-common-svc/guac-common-svc.c:21:
> 469.2
/opt/guacamole/lib/pkgconfig/../../include/freerdp3/freerdp/codecs.h:93:9:
error: 'codecs_free' is deprecated: [since 3.6.0] Use
freerdp_client_codecs_free [-Werror=deprecated-declarations]
> 469.2 93 | WINPR_DEPRECATED_VAR("[since 3.6.0] Use
freerdp_client_codecs_new",
> 469.2 | ^~~~~~~~~~~~~~~~~~~~
> 469.2 In file included from
/opt/guacamole/lib/pkgconfig/../../include/winpr3/winpr/winpr.h:22,
> 469.2 from
/opt/guacamole/lib/pkgconfig/../../include/winpr3/winpr/stream.h:26,
> 469.2 from
/opt/guacamole/lib/pkgconfig/../../include/freerdp3/freerdp/freerdp.h:25:
> 469.2
/opt/guacamole/lib/pkgconfig/../../include/freerdp3/freerdp/codecs.h:91:47:
note: declared here
> 469.2 91 | FREERDP_API void
codecs_free(rdpCodecs* codecs));
> 469.2 | ^~~~~~~~~~~
> 469.2
/opt/guacamole/lib/pkgconfig/../../include/winpr3/winpr/platform.h:497:41:
note: in definition of macro 'WINPR_DEPRECATED_VAR'
> 469.2 497 | #define WINPR_DEPRECATED_VAR(text, obj) obj
__attribute__((deprecated(text)))
> 469.2 | ^~~
> 469.2 cc1: all warnings being treated as errors
> 469.2 make[4]: Leaving directory '/tmp/guacamole-server/src/protocols/rdp'
> 469.2 make[4]: *** [Makefile:1432:
plugins/guac-common-svc/libguac_common_svc_client_la-guac-common-svc.lo] Error 1
> 469.2 make[3]: *** [Makefile:1486: all-recursive] Error 1
> 469.2 make[3]: Leaving directory '/tmp/guacamole-server/src/protocols/rdp'
> 469.2 make[2]: *** [Makefile:768: all] Error 2
> 469.2 make[2]: Leaving directory '/tmp/guacamole-server/src/protocols/rdp'
> 469.2 make[1]: *** [Makefile:545: all-recursive] Error 1
> 469.2 make[1]: Leaving directory '/tmp/guacamole-server'
> 469.2 make: *** [Makefile:465: all] Error 2
> ------
>
> 1 warning found (use docker --debug to expand):
> - JSONArgsRecommended: JSON arguments recommended for CMD to prevent
unintended behavior related to OS signals (line 219)
> Dockerfile:154
> --------------------
> 152 |
> 153 | # Build guacamole-server and its core protocol library
dependencies
> 154 | >>> RUN ${BUILD_DIR}/src/guacd-docker/bin/build-all.sh
> 155 |
> 156 | # Determine location of the FREERDP library based on the
version.
> --------------------
> ERROR: failed to solve: process "/bin/sh -c
${BUILD_DIR}/src/guacd-docker/bin/build-all.sh" did not complete successfully:
exit code: 2
> ```
A dirty _working_ fix for now,
`src/guacd-docker/bin/build-all.sh` Line 30
```bash
export CFLAGS="-I${PREFIX_DIR}/include -Wno-error=deprecated-declarations"
```
`Dockerfile` Line 128-129:
```bash
-DWITH_ZLIB=ON \
-DDISABLE_WERROR=ON"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
