weberr13 commented on code in PR #560:
URL: https://github.com/apache/guacamole-server/pull/560#discussion_r2190822253
##########
src/protocols/rdp/client.c:
##########
@@ -130,6 +131,16 @@ static int guac_rdp_join_pending_handler(guac_client*
client) {
/* Bring user up to date with any registered static channels */
guac_rdp_pipe_svc_send_pipes(client, broadcast_socket);
+ /* Get max secondary monitors */
+ char* max_monitors = guac_mem_alloc(12);
+ guac_itoa(max_monitors,
+ (unsigned int) rdp_client->settings->max_secondary_monitors);
+
+ /* Send current max allowed secondary monitors */
+ guac_client_stream_argv(client, broadcast_socket, "text/plain",
+ "secondary-monitors", max_monitors);
+ guac_mem_free(max_monitors);
Review Comment:
same concern as above, who "owns" the char* max_monitors? does
guac_client_stream_argv copy from max_monitors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
