necouchman commented on code in PR #1128:
URL: https://github.com/apache/guacamole-client/pull/1128#discussion_r2533771771
##########
extensions/guacamole-auth-radius/src/main/resources/translations/tr.json:
##########
@@ -4,4 +4,9 @@
"NAME" : "RADIUS Altyapısı"
},
+ "LOGIN" : {
+ "FIELD_HEADER_GUAC_RADIUS_STATE" : "",
+ "FIELD_HEADER_RADIUSCHALLENGE" : ""
+ }
Review Comment:
You do not need to put empty strings like this in the translation files -
they are automatically pulled from the English translation.
##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/translations/tr.json:
##########
@@ -17,6 +17,9 @@
},
"LOGIN" : {
+ "FIELD_HEADER_ID_TOKEN" : "",
+ "FIELD_HEADER_STATE" : "",
+ "FIELD_HEADER_TICKET" : "",
Review Comment:
Please remove empty translation strings.
##########
extensions/guacamole-auth-duo/src/main/resources/translations/tr.json:
##########
@@ -5,6 +5,7 @@
},
"LOGIN" : {
+ "FIELD_HEADER_GUAC_DUO_SIGNED_RESPONSE" : "",
Review Comment:
You do not need to put empty strings like this in the translation files -
they are automatically pulled from the English translation.
##########
extensions/guacamole-auth-totp/src/main/resources/translations/tr.json:
##########
@@ -4,6 +4,10 @@
"NAME" : "TOTP TFA Altyapısı"
},
+ "LOGIN" : {
+ "FIELD_HEADER_GUAC_TOTP" : ""
+ },
Review Comment:
Please remove empty translation strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
