mike-jumper commented on PR #1135: URL: https://github.com/apache/guacamole-client/pull/1135#issuecomment-3638572075
I definitely think we shouldn't rely on an externally set cookie to determine core behavior. The webapp should perform its own checks and decide on preference defaults. While we can't just look at whether touch events are supported (we need to support devices that have both a physical keyboard and a touch screen), there should be other mechanisms we can use to hint at better defaults. Other options: * There may be something we can leverage in the [VirtualKeyboard API](https://developer.mozilla.org/en-US/docs/Web/API/VirtualKeyboard_API) for some browsers (though we would still have to rely on browser sniffing for others). * We try to detect whether the virtual keyboard ever opens up while the user is interacting with the webapp, and attempt to focus the `Guacamole.InputSink` upon connecting to ensure we can rely on this happening at least once. If the virtual keyboard ever opened up, then we should default to mobile-friendly behavior. If it didn't, then no action is needed and having `Guacamole.InputSink` focused doesn't hurt anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
