necouchman commented on PR #1117: URL: https://github.com/apache/guacamole-client/pull/1117#issuecomment-3650864468
> In terms of communication with guacd: > > * Would it be okay to use the `SESSION_TIMEOUT` error code or should I make my own? Or possibly just use the 'disconnect' handler on the guacd side? I'm tempted to say make another one, because of things I've mentioned above - the implementation, here, isn't so much a "timeout" as it is a limit. To me, "timeout" carries a notion of waiting for something - user interaction, a network response, etc. - and not getting that. In this case, you're actually putting a cap on the session duration regardless of whether the user is active or not, the server is responsive or not, etc. > * If the client needs to send information back to `guacd` when tunnels are closed, why isn't a message isn't sent `tunnel.close()` implementations by default? I would guess there just hasn't been a need for it in the past. It could probably be added - my only caution would be to make sure that adding it doesn't break compatibility with clients that don't send a message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
