mike-jumper commented on code in PR #1145:
URL: https://github.com/apache/guacamole-client/pull/1145#discussion_r2666732168
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -86,6 +86,7 @@
"ERROR_CLIENT_201" : "This connection has been closed because the
server is busy. Please wait a few minutes and try again.",
"ERROR_CLIENT_202" : "The Guacamole server has closed the
connection because the remote desktop is taking too long to respond. Please try
again or contact your system administrator.",
"ERROR_CLIENT_203" : "The remote desktop server encountered an
error and has closed the connection. Please try again or contact your system
administrator.",
+ "ERROR_CLIENT_205" : "This connection is currently in use, and
concurrent access to this connection is not allowed. Please try again later.",
Review Comment:
While it may be the case that the connection is already in use, this error
code (`RESOURCE_CONFLICT`) is defined as:
> A resource is already in use or locked, preventing the requested operation.
(https://guacamole.apache.org/doc/gug/protocol-reference.html#status-codes)
Thus, this code can be produced for any resource that can't be shared. The
conflicting resource could be in use by a different connection and is not
necessarily the connection itself.
My recommendation would be something like: "This connection requires a
resource that is currently in use, but shared access to that resource is either
not possible or not permitted. Please try again later."
For cases where it's the entire connection that conflicts,
`SESSION_CONFLICT` (already defined with `ERROR_CLIENT_209`) would be more
appropriate:
https://github.com/apache/guacamole-client/blob/593f5096bb5eff36846eb30e49f5ab0f6959e276/guacamole/src/main/frontend/src/translations/en.json#L91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
