aleitner commented on code in PR #610: URL: https://github.com/apache/guacamole-server/pull/610#discussion_r2677561801
########## src/libguac/guacamole/protocol.h: ########## @@ -1155,5 +1155,42 @@ guac_protocol_version guac_protocol_string_to_version(const char* version_string */ const char* guac_protocol_version_to_string(guac_protocol_version version); -#endif +/** + * Sends a usbdisconnect instruction over the given guac_socket connection, + * requesting that the client disconnect the specified USB device. + * + * @param socket + * The guac_socket connection to use. + * + * @param device_id + * The unique identifier of the USB device that should be disconnected. + * + * @return + * Zero on success, non-zero on error. + */ +int guac_protocol_send_usbdisconnect(guac_socket* socket, + const char* device_id); + +/** + * Sends a usbdata instruction over the given guac_socket connection, + * sending USB data to a specific endpoint on a client-side USB device. + * + * @param socket + * The guac_socket connection to use. + * + * @param device_id + * The unique identifier of the USB device. + * + * @param endpoint_number + * The endpoint number to send data to. Review Comment: I'll update documentation, but just to clarify USB endpoints are communication channels within a USB device. Each endpoint has a number and direction (IN/OUT). Multiple endpoints allow simultaneous communication channels over the same USB connection. The valid endpoint numbers for a device should be provided in the `interface_data` during usbconnect -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
