subbareddyalamur commented on PR #1163: URL: https://github.com/apache/guacamole-client/pull/1163#issuecomment-3932739937
> @subbareddyalamur I certainly like the new approach better - I think calling the existing functions is preferable to rewriting all of the logic within that block. That said, I'm still a little unsure as to whether or not we want to preload the data for _all_ of the connections? It seems like there ought to be a way to have the resolution of these tokens done after the connection is selected? @necouchman Not feasible without changes to the JDBC tunnel layer. The resolution would require introducing a new hook in AbstractGuacamoleTunnelService (JDBC layer), which is out of scope for a vault-only fix. The pre-resolution approach is a tradeoff — slightly more work upfront, but it stays within the vault extension's boundaries without touching the core tunnel service -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
