mike-jumper commented on code in PR #633: URL: https://github.com/apache/guacamole-server/pull/633#discussion_r3024463043
########## src/protocols/rdp/aad.c: ########## @@ -0,0 +1,1072 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "config.h" + +#ifdef HAVE_FREERDP_AAD_SUPPORT + +#include "aad.h" + +#include <guacamole/client.h> +#include <guacamole/mem.h> +#include <guacamole/string.h> + +#include <curl/curl.h> +#include <stdlib.h> +#include <string.h> + +/** + * Azure AD OAuth2 token endpoint URL format. + * The %s placeholder is replaced with the tenant ID. + */ +#define GUAC_AAD_TOKEN_ENDPOINT \ + "https://login.microsoftonline.com/%s/oauth2/v2.0/token"; + +/** + * Azure AD OAuth2 authorization endpoint URL format. + * The %s placeholder is replaced with the tenant ID. + */ +#define GUAC_AAD_AUTHORIZE_ENDPOINT \ + "https://login.microsoftonline.com/%s/oauth2/v2.0/authorize"; + +/** + * The native client redirect URI used for the authorization code flow. + * This is a special Microsoft-provided redirect URI for non-web applications. + */ +#define GUAC_AAD_NATIVE_REDIRECT_URI \ + "https://login.microsoftonline.com/common/oauth2/nativeclient"; + +/** + * Maximum size for the login page HTML response. + */ +#define GUAC_AAD_LOGIN_PAGE_MAX_SIZE (64 * 1024) + +/** + * HTTP request timeout in seconds. + */ +#define GUAC_AAD_HTTP_TIMEOUT_SECONDS 30 + +/** + * User-Agent string sent with all HTTP requests to Microsoft login endpoints. + * A browser-like UA is required to avoid "unsupported browser" responses. + */ +#define GUAC_AAD_USER_AGENT \ + "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 " \ + "(KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36" Review Comment: Unfortunately, phoning Google from within guacd is going to be a privacy issue. I don't think we can go this route. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
