necouchman commented on code in PR #457:
URL: https://github.com/apache/guacamole-client/pull/457#discussion_r3037661130
##########
guacamole/src/main/frontend/src/app/form/templates/dateField.html:
##########
@@ -9,5 +9,6 @@
guac-focus="focused"
placeholder="{{'FORM.FIELD_PLACEHOLDER_DATE' | translate}}"
autocorrect="off"
- autocapitalize="off">
+ autocapitalize="off"
+ autocomplete="{{ field.autocomplete }}"/>
Review Comment:
Maybe so, but:
* I didn't find any references to `ng-attr-autocomplete` in the AngularJS
documentation, so wasn't sure if it was valid. Is it just a general rule that
`ng-attr-<anything>` maps to the `<anything>` tag property?
* The above code seems to work, at least in my somewhat limited testing, so
it doesn't seem to be necessary, though maybe it's preferred?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
