adb014 commented on PR #1198: URL: https://github.com/apache/guacamole-client/pull/1198#issuecomment-4217751935
Looking at the discussion in #517, I finally decided to add the well-known endpoint and an enum for the response_type to limit the values allowed. Given this it was also easy to add the use of "token" response_types as discussed in #517 for AWS Cognito. A minimal guacamole.properties can then be ``` openid-response-type: id_token | token | code openid-well-known-endpoint: https://identity-provider/well-known openid-token-endpoint: https://identity-provider/token openid-client-id: my-client-id openid-client-secret: my-client-secret | null openid-pkce-required: true | false openid-redirect-uri: https://example.net/guacamole ``` Can't see anything else to add to this patch. Can someone review it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
