bbennett-ks commented on code in PR #671:
URL: https://github.com/apache/guacamole-server/pull/671#discussion_r3205740358
##########
configure.ac:
##########
@@ -720,6 +720,30 @@ then
fi
+#
+# libVNCServer support for the Extended Clipboard pseudo-encoding, which
+# allows clipboard text to be exchanged as UTF-8 via SendClientCutTextUTF8()
+# and the GotXCutTextUTF8 callback. Both were added in libvncserver 0.9.15.
+# If support is missing, Guacamole falls back to the classic VNC clipboard
+# with iconv-based encoding conversion.
+#
+
+if test "x${have_libvncserver}" = "xyes"
+then
+
+ have_vnc_extended_clipboard=yes
+ AC_CHECK_MEMBERS([rfbClient.GotXCutTextUTF8],
+ [], [have_vnc_extended_clipboard=no],
+ [[#include <rfb/rfbclient.h>]])
+
+ if test "x${have_vnc_extended_clipboard}" = "xyes"
+ then
+ AC_DEFINE([LIBVNC_CLIENT_HAS_EXTENDED_CLIPBOARD],,
+ [Whether rfbClient supports the Extended Clipboard
pseudo-encoding (UTF-8).])
+ fi
+
+fi
Review Comment:
Thanks for the tip! I modeled the fix based on support for `libVNCserver
support for the requestedResize`. I'll keep this in mind for next my.
FYI, I implemented similar support for `libVNCServer support
FinishedFrameBufferUpdate`. Once I began to test it, I realized the the base
`libVNCServer` in GitHub supported `FinishedFrameBufferUpdate` so config
support was not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
