GitHub user mike-jumper opened a pull request:

    https://github.com/apache/incubator-guacamole-server/pull/9

    GUACAMOLE-34: Ensure client is cleaned up whenever the client thread 
terminates.

    From [GUACAMOLE-34](https://issues.apache.org/jira/browse/GUACAMOLE-34):
    
    > This is caused by the lack of `guac_client_abort()` or 
`guac_client_stop()` call in some cases where the client thread otherwise 
terminates. The connection will full close under ONLY the following 
circumstances:
    > 
    > 1. All users disconnect (close their browser tabs, manually select 
"Disconnect" within the guac menu, etc.)
    > 2. `guac_client_stop()` is called
    > 3. `guac_client_abort()` is called
    > 
    > If the internal client disconnects and terminates its own thread, it 
should also invoke `guac_client_stop()` or `guac_client_abort()` to ensure 
connected users are forced off. Otherwise, users will be confused why their 
connection remains active with an unresponsive remote desktop session.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/incubator-guacamole-server 
fix-connection-close

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-server/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
    
----
commit a64c3e017907712ed23e902d7843a5653a26bba7
Author: Michael Jumper <[email protected]>
Date:   2016-04-19T01:15:32Z

    GUACAMOLE-34: Ensure guac_client_stop() or guac_client_abort() are called 
in ALL cases where the client thread terminates.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to