Github user vchrisb commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/10#discussion_r64998961
--- Diff: guacamole-docker/bin/start.sh ---
@@ -90,15 +90,21 @@ set_optional_property() {
## instead of a linked container.
##
associate_mysql() {
-
- # Use linked container if specified
- if [ -n "$MYSQL_NAME" ]; then
- MYSQL_HOSTNAME="$MYSQL_PORT_3306_TCP_ADDR"
- MYSQL_PORT="$MYSQL_PORT_3306_TCP_PORT"
- fi
-
- # Use default port if none specified
- MYSQL_PORT="${MYSQL_PORT-3306}"
+ : ${MYSQL_HOSTNAME:=mysql}
--- End diff --
Using `MYSQL_PORT_3306_TCP_ADDR` and `MYSQL_PORT_3306_TCP_PORT` is
deprecated as of [Link environment variables
reference](https://docs.docker.com/compose/link-env-deprecated/).
Linked services are reachable by the service name or its alias. In this
case the alias of the database service is `mysql`. Please see
[Links](https://docs.docker.com/compose/compose-file/#links).
Docker is either adding a `Hosts`entry for the linked docker image, newer
docker versions do have a build in DNS server.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
