Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65447441
--- Diff: guacamole-docker/README.md ---
@@ -129,17 +126,17 @@ Deploying Aoache Guacamole with LDAP authentication
-e LDAP_CONFIG_BASE_DN=ou=connections,dc=example,dc=com \
-d -p 8080:8080 glyptodon/guacamole
-Linking Guacamole to your LDAP directory will require additional
configuration parameters
+Using Guacamole with your LDAP directory will require additional
configuration parameters
specified via environment variables. These variables collectively describe
how Guacamole
will connect to LDAP:
-1. `LDAP_HOSTNAME` - The base of the DN for all Guacamole users.
+1. `LDAP_HOSTNAME` - The hostname or IP address of your LDAP server.
2. `LDAP_USER_BASE_DN` - The base of the DN for all Guacamole users.
3. `LDAP_PORT` - The port your LDAP server listens on. (Optional)
--- End diff --
If you think that's better, then cool. I'm more of the mind that separate
would be easier to read, but I don't think this way is bad in itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
